Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release staging v1.4.6 #846

Merged
merged 17 commits into from
Sep 15, 2022
Merged

Release staging v1.4.6 #846

merged 17 commits into from
Sep 15, 2022

Conversation

martinstibbe
Copy link
Contributor

@martinstibbe martinstibbe commented Sep 15, 2022

Description

Release staging v1.4.6

Link to any related issue(s):

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the Terraform contribution guidelines
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code

Further comments

martinstibbe and others added 13 commits September 8, 2022 12:47
…led = false (#823)

* Add support to ignore export bucket when auto_export_enabled = false

* Update mongodbatlas/resource_mongodbatlas_cloud_backup_schedule.go

Co-authored-by: Andrea Angiolillo <[email protected]>

* go fmt

* go fmt

Co-authored-by: Andrea Angiolillo <[email protected]>
…ccess list (#834)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* INTMDB-354: [Terraform] Update docs around what requires an API key access list

* Expand detail in documentation for API key list

* Add additional resources that require API Key access list

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…832)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update key rotation alert to 90 days vs 365

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…erverless_instance (#830)

* Add support for ServerlessContinuousBackupEnabled

* Update datasources, tests and documentation

* Update docs add link for backup information
…dpointRegionalMode_basic test to use a new project to prevent conflicts (#837)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* MONGODB_ATLAS_NETWORK_PROJECT_ID to permit multi region testing to run in different project

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add Azure as validation candidate for NVME

* Split out Azure setting

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Update project_invitation documentation and removed validations on roles

* Updated role documentation on project_invitation

* Added role documentation onto the argument reference
…- issue 768 (#839)

* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Add support to migrate  legacy backup parameter to cloud_backup value

* Update error message

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Chore(deps): Bump github.com/gruntwork-io/terratest (#825)

Bumps [github.com/gruntwork-io/terratest](https://github.com/gruntwork-io/terratest) from 0.40.20 to 0.40.21.
- [Release notes](https://github.com/gruntwork-io/terratest/releases)
- [Commits](gruntwork-io/terratest@v0.40.20...v0.40.21)

---
updated-dependencies:
- dependency-name: github.com/gruntwork-io/terratest
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update build to go 1.18

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Updated privatelink_endpoint CD endpoints to match refresh func timeout

* Using Configured timeout times in refresh func

* Updated docs to contain timeout instructions

* Corrected default timeout value on privatelink_endpoint

* Moved the timeout documentation to the resource

* PrivateLink Endpoint documentation refers to the proper resource and includes an example

* Fixed casing on Private Endpoint

* Added to docs on how to learn more about timeouts
Copy link
Collaborator

@Zuhairahmed Zuhairahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where existing INTMDB tickets exist we should include in title of commit to make easier to check that all tickets from JIRA tagged for this release are included.

For example below are missing tags:

  1. Add support for use_org_and_group_names_in_export_prefix parameter - should be tagged to INTMDB-385
  2. Update tests related to alert configuratiopn - should be tagged to INTMDB-372. also minor typo in commit title "configuratiopn"

Otherwise LGTM

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except we need links per my comments. Please do that before release.

CHANGELOG.md Outdated
Comment on lines 6 to 19
- INTMDB-387 - [Terraform] Enable Azure NVME for Atlas Dedicated clusters
- INTMDB-342 - [Terraform] Update TestAccDataSourceMongoDBAtlasPrivateEndpointRegionalMode_basic test to use a new project to prevent conflicts
- INTMDB-347 - [Terraform] cloud_backup is not being correctly imported - issue [\#768](https://github.com/mongodb/terraform-provider-mongodbatlas/issues/768)
- INTMDB-354 - [Terraform] Update docs around what requires an API key access list
- INTMDB-363 - [Updated Feature] Add serverless backup to mongodbatlas_serverless_instance
- INTMDB-379 - [Terraform] Release 1.4.6 (both pre and then GA)
- INTMDB-381 - [Terraform] Customer is unable to disable backup auto export
- INTMDB-383 - [Terraform] Update the BYOK/encryption at rest resource
- INTMDB-385 - use_org_and_group_names_in_export_prefix is not working for a customer
- INTMDB-386 - [Terraform] Add new role types to invitation verification
- INTMDB-371 - [Terraform] Timeout when creating privatelink_endpoint
- INTMDB-372 - [Terraform] Fix failing test for testAccMongoDBAtlasAlertConfigurationConfigWithMatchers
- INTMDB-358 - [terraform] Upgrade to go1.18
- INTMDB-391 - [Terraform] Doc Fix for teams.html.markdown
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make sure these are pointing to either an issue or a PR (and the issue should have the PR it links to). Not going to block on this but please fix before the release.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed changelog

Copy link
Collaborator

@themantissa themantissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the Changelog attention.

@themantissa themantissa merged commit cb4868f into master Sep 15, 2022
@themantissa themantissa deleted the release-staging-v1.4.6 branch September 15, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants